Repository navigation
Test that installcheck creates a missing test/sql/ - #100
Merged
jnasbyupgrade merged 1 commit intoOct 7, 2026
Merged
jnasbyupgrade merged 1 commit into
jnasbyupgrade merged 1 commit into
Conversation
Add tests for pgxntool commit 1fe6987 (Postgres-Extensions/pgxntool#133): - The `$(TESTDIR)/sql` directory rule now matches `installcheck`'s `$(TESTDIR)/sql/` order-only prerequisite, so `make test` works in a project without test/sql/ `base-mk-misc.bats` runs `make -n installcheck` with TESTDIR pointed at a directory that doesn't exist, and asserts the rules for sql/, expected/ and results/ all resolve. Overriding TESTDIR reproduces a project without test/sql/ without changing the shared test environment, which setup.sh has already given a test/sql/. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jnasbyupgrade
added a commit
to Postgres-Extensions/pgxntool
that referenced
this pull request
Oct 7, 2026
`make test` failed with `No rule to make target 'test/sql/', needed by 'installcheck'` in a project with no `test/sql/` directory. The rule that creates the directory was spelled `$(TESTDIR)/sql` while `installcheck`'s order-only prerequisite is `$(TESTDIR)/sql/`, and make treats those as different targets. The rule now targets `$(TESTDIR)/sql/`, matching its `expected/` and `results/` siblings; `test-build` is fixed too, since it runs `installcheck` recursively. `setup.sh` normally creates `test/sql/`, which hid this. **Merge this first**, then Postgres-Extensions/pgxntool-test#100, which tests it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds coverage for Postgres-Extensions/pgxntool#133. That PR fixes
make testfailing withNo rule to make target 'test/sql/', needed by 'installcheck'in a project with notest/sql/directory.The new
@testintest/standard/base-mk-misc.batsrunsmake -n installcheckwithTESTDIRpointed at a directory that doesn't exist. It asserts that make succeeds and printsmkdir -pforsql/,expected/andresults/.make -nshows that without Postgres or a realpg_regressrun, so no end-to-end test is needed.TESTDIR:setup.shalways createstest/sql/, so the foundation environment can't show the bug. PointingTESTDIRat a fresh scratch path reproduces it without moving directories in the shared test environment.Proven both ways:
make: *** No rule to make target '.../base-mk-misc-scratch/test/sql/', needed by 'installcheck'. Stop.Merge order
Merge Postgres-Extensions/pgxntool#133 first, then this PR. This is an addition: the new test needs the fixed rule. If this PR merges first, the test fails on every unrelated pgxntool-test PR's CI until the pgxntool PR lands.
🤖 Generated with Claude Code