Repository navigation
feat(root): remove reindex and backfill - #32
Merged
Merged
Conversation
Both were no-ops since search moved to PostgreSQL (PPT-2644), deprecated in #29, and rest-api has now removed the endpoints (PlaceOS/rest-api#454), so they only answered 404. ReindexOptions goes with them. Released as a minor: nothing in PlaceOS calls either. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
🎉 This PR is included in version 6.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
reindex,backfillandReindexOptions. They've been no-ops since search moved to PostgreSQL (PPT-2644), were deprecated in #29, and PlaceOS/rest-api#454 removes the endpoints, so they'd only get a 404.Release: a minor (
feat, no!), agreed with the maintainer. Strict semver would make this a major, but no PlaceOS frontend calls either function. Merge it once rest-api#454 is out, so the client never lacks a function the server still has.Testing:
npm run build(tsc + vite) passes.vitest run: 566 passed, and the same 23 fail on master, all inauth/functions.spec.tsandhttp/expired-token.spec.ts.eslintcrashes on master too (a repo config problem), so it wasn't run.🤖 Generated with Claude Code