Repository navigation
feat(history): lazily built metadata provider - #338
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
18 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #336
History.with_metadataalso accepts aHistory::MetadataProvider(Proc(Metadata)), which is only called when a change is recorded.rest-api wraps each request in an around filter, and those run before
authorize!. With a provider, the metadata can include the user once the request has been authenticated, and requests that don't change anything never build it.The fiber metadata hash is now guarded by a mutex, so it is safe in multi-threaded builds.
Review
./test: 858 examples, 0 failures.with_metadatabegan.🤖 Generated with Claude Code