Repository navigation
[PER-10768] Add preview placeholders for files that are still processing, can't see or failed to preview - #1198
Open
aasandei-vsp wants to merge 5 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## PER-10680-migrate-navigate-lean-refresh-current-folder #1198 +/- ##
==========================================================================================
+ Coverage 54.53% 54.72% +0.18%
==========================================================================================
Files 368 372 +4
Lines 12914 12990 +76
Branches 2367 2383 +16
==========================================================================================
+ Hits 7043 7109 +66
- Misses 5634 5643 +9
- Partials 237 238 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
aasandei-vsp
force-pushed
the
PER-10680-migrate-navigate-lean-refresh-current-folder
branch
from
October 7, 2026 09:29
30cbc66 to
12b5d5a
Compare
In order to map and show the status of a record, we need the BE to provide a property that will decide in which state the preview of the file it is. Issue: PER-10768
Some record previews depend on the state a copy is, but some don't. For example, images and videos are rendered as they are, so we need to decide which records do need to consider the preview state and which don't. Issue: PER-10768
Every state that comes from the backend will yield into a different preview, so the copy and SVGs will change accordingly. This way, the user will be more accurately informed about the state of their file. Issue: PER-10768
The existing preview component already tackles all of the types of records we can upload, but not the status a record is in or if the record cannot be viewed. So we have integrated the status preview component for this exceptional cases. Issue: PER-10768
Issue: PER-10768
aasandei-vsp
force-pushed
the
PER-10768-no-access-copy-yet-v2
branch
from
October 8, 2026 12:27
312e60f to
ae01846
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds preview placeholders for files that are still processing, can't actually be previewed or the BE failed to generate a copy for previewing. This applies mostly to docx file and such, but it also shows a nice preview page for files like archives, that we cannot actually see in the browser.
Issue: PER-10768
Click here to view curated manual test cases
# Manual test cases — record preview states (PER-10768, part 1)The visible change: opening a record that has no viewable copy yet now shows a nice friendly screen, with and accurate message about the state of the file copy.
Preparing a copy ⭐
Scenario — a document straight after upload
.docxand open it in the viewer straight away.We're still preparing this file to view..docxdownloads.Scenario — formats whose original the browser can't show ⭐
.tiffand open it straight away. --> NEEDS TESTING ON DEVWe're still preparing this file to view..heic, the.aviand the.wma.We're still preparing this file to view..tiffonce its copy is ready.Files that show from their original
(cheap regression checks: these must look exactly as before)
Scenario — opening straight after upload
.jpg,.mp4,.mp3and.pdf, and open each one straight away.Can't show it here
Scenario — a format that never gets a copy
.zipand open it.This file is stored, but we can't show it here, withZIPon the icon and on Download original, and the linkWhich files can Permanent preview?.Failed copy
Scenario — an old document without a copy
(only if your archive has one) --> THIS CAN BE EASILY TESTED ON LOCAL(we don't seem to make copies there)
.docxthat is more than a day old and never got a copy.We couldn't make a copy of this file to view, Download original, and the linkGet help with this file.Moving around while a copy is being prepared
Scenario — arrows and closing
.docxfrom a folder that also holds the.jpg, and use the arrows to move to the.jpg..docx..docxis still preparing, wait a minute, and open the.jpg..jpgopens normally, with no errors.Sharing
Scenario — an unlisted share link
.docxwith an unlisted link, and open the link in a private window.