Repository navigation
CI: add weekly test against Parcels main - #419
Merged
Merged
Conversation
Collaborator
Author
|
@VeckoTheGecko Erik and I discussed this earlier and I've had a go at doing something similar to Parcels for VirtualShip. Let us know if you have time to have a quick look and if you have any thoughts! |
erikvansebille
left a comment
erikvansebille
left a comment
Member
There was a problem hiding this comment.
Looks good to me, but I'd prefer if @VeckoTheGecko also reviews this PR
Collaborator
|
This looks good. I pushed some minor edits. I'm going to do some testing post-merge |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed with @erikvansebille earlier, and flagged in #418, it would be helpful to have CI which runs tests weekly against Parcels as the API may change.
This PR implements a weekly test run pulling in main from Parcels, so hopefully breaking API changes in Parcels v4 will be flagged. It should also automate a new Issue.