Repository navigation
Conversation
erikvansebille
left a comment
erikvansebille
left a comment
Member
There was a problem hiding this comment.
Looks good - one very small comment (and a reflection) below
| | **XBT** | TEMPERATURE | Sea Water Potential Temperature | °C | Physical | | ||
|
|
||
| ```{note} | ||
| The `ARGO_FLOAT` BGC sensors (oxygen, chlorophyll, nitrate, ph) are off by default. Each extra sensor adds another variable for the simulation to load and sample, which can make the already-expensive Argo float simulations more intensive. When needed though, they can be turned on in the `virtualship plan` tool or by adding them to the `sensors` list of `argo_float_config` in `expedition.yaml`. |
Member
There was a problem hiding this comment.
Mixing the words "expensive" and "intensive" may be confusing. Reword?
| # ===================================================== | ||
|
|
||
|
|
||
| def _sample_on_ascent(particles, field, var): |
Member
There was a problem hiding this comment.
Nice improvement to make this its own function! Shows the flexibility of Parcels v4 ;-)
Collaborator
Author
There was a problem hiding this comment.
Yes this is a really nice feature of v4!
erikvansebille
approved these changes
Oct 21, 2026
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds biogeochemical variables to the Argo Float instrument, by adding them as available sensors to the instrument.
The only BGC variables which are added to Argo floats are those that are both used on real-life BGC-Argo floats and are available from Copernicus. That means oxygen, chlorophyll, nitrate and pH. A BGC CTD for example has a wider range of sensors but restricting it on the Argo floats is more realistic.
Note also that the BGC sensors are off by default in an expedition. Adding additional fields adds more expense to the Argo float simulations, which are already quite intensive, so I see it as a trade off between having them available to users should they want them but not encouraging everyone use them if they don't need them.
On a related note, there are changes to the
virtualship plantool which means the BGC sensors appear as options in the instrument config sections but are default off. Previously all instruments sensors were on by default so it wasn't a concern that they wouldn't show as options in the plan tool. The docs now also have updates to explain that the BGC sensors are available for Argo floats but off by default.Closes #234