Repository navigation
Use depth dependence and a per-waypoint model for stationkeeping time #411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
a8a1e0a
move verify methods up to Expedition model; give method names reflect…
j-atkins 8d35fc7
move sensor_kernels check to register_instrument rather than __init__…
j-atkins 69d429a
add deceleration and acceleration times to ship config
j-atkins f5f59ec
enforce each instrument has an abstract deployment_time method (CTD d…
j-atkins 952ce82
move stationkeeping_time to Expedition model; use new model of statio…
j-atkins 45b9ed5
remove now redundant INSTRUMENT_CONFIG_MAP
j-atkins d1aad15
remove stationkeeping_time fields from instrument configs
j-atkins 9e0b3ff
update docs to reflect new stationkeeping_time model + information on…
j-atkins 6051b8b
update test for updated stationkeeping time calcs
j-atkins df4a9c2
remove unnecessary messaging and remove references to now deleted
j-atkins 9b9d755
add ship deceleration and acceleration times to the plan tool
j-atkins 49b301f
revert plan tool changes, need to consider how want to present this t…
j-atkins 8cdcb14
add deceleration and acceleration fields to plan TUI
j-atkins 28e8a21
Apply suggestion from @erikvansebille
j-atkins 171de72
explicit about default times for slow down and speed up
j-atkins e7174b3
"deceleration"/"acceleration" -> "slow-down"/"speed-up" times
j-atkins 677f905
"station" -> "waypoint"
j-atkins 4f794b2
new class attribute allowing specify whether ship needs to slow down …
j-atkins 149e623
Merge branch 'depth-dependent-stationkeeping' of github.com:OceanParc…
j-atkins 15ade71
make docstring more consistent with rest of codebase lingo
j-atkins 801b4cf
add more docs info on times stationkeeping time per instrument
j-atkins a0e6b07
Merge remote-tracking branch 'origin/main' into depth-dependent-stati…
j-atkins 4883e28
typos and make differences between ctd and xbt timings clearer
j-atkins 20210d2
fix duplication mistake
j-atkins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does drifters now have the same new sentence twice? o is that a rendering mistake in my git diff?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops that's my mistake, good spot thanks!