Repository navigation
fixed _get_offsets_dictionary - #3010
Merged
Merged
Conversation
for more information, see https://pre-commit.ci
…/Parcels into _get_offsets_dictionary-bug
erikvansebille
left a comment
erikvansebille
left a comment
Member
There was a problem hiding this comment.
Good catch, @wyatt-fluidnumerics! Does it also need its own unit test? Or will that be part of #3012?
Contributor
Author
Added in 3ca266f |
erikvansebille
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes _get_offsets_dictionary to correctly report face index offset for
BOTHpadding.Checklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure
None Used