Repository navigation
Cleanup skipped and xfailed unittests - #3008
Draft
erikvansebille wants to merge 17 commits into
Draft
erikvansebille wants to merge 17 commits into
erikvansebille wants to merge 17 commits into
Conversation
erikvansebille
changed the title
As I think that duplicate axes are now supported by model.py
erikvansebille
commented
Oct 26, 2026
| @pytest.mark.skip(reason="Pending ParticleFile refactor; see issue #2386") | ||
| @pytest.mark.parametrize("dt", [-np.timedelta64(1, "s"), np.timedelta64(1, "s")]) | ||
| @pytest.mark.parametrize("maxvar", [2, 4, 10]) | ||
| def test_pset_repeated_release_delayed_adding_deleting(fieldset, tmp_parquet, dt, maxvar): |
Member
Author
There was a problem hiding this comment.
I spent quite some time on making this test work for v4, but then decided that it was too complex because the parquet format and the kernel loop have changed so much. So I suggest to remove it - we test/check output in tutorials and on other places
erikvansebille
commented
Oct 26, 2026
| @pytest.mark.skip( | ||
| "Needs updating after refactoring from https://github.com/Parcels-code/Parcels/pull/2646" | ||
| ) # TODO: I think we can just rely on the SGRID metadata for this (which already has robust error messaging). How should discrepencies between SGRID and axis attr be handled? | ||
| def test_dim_with_duplicate_axis(): |
Member
Author
There was a problem hiding this comment.
This test now seems to pass. Parcels doesn't throw an error when a Variable has two dimensions with the same axis. Is that expected?
Since it failed on min-versions test
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up some of the (failing/skipped) unit tests - thereby also making some small fixes to
src. Somewhat tangentially, it also renames the .localize function to .localise, as we (try to) adhere to UK spelling in Parcels.Checklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure
None