Repository navigation
Recover loading states after profile and first-sync failures - #51
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a profile changes while a book file is loading, close the loading state with an explanation and a working Back action instead of leaving the spinner or opening the old profile's book. When first sync fails with an empty cache, Goals now displays the existing offline-library placeholder on both tabs and recovers automatically after sync succeeds.
Validation: 47 focused reader-page, Goals-page/provider and real PowerSync state-transition tests pass; formatting and Flutter analysis pass. The reader regression invalidates the captured scoped repository while media I/O is pending and verifies that no reader document opens. The Goals tests cover both visible tabs and recovery from a real PowerSync download error. Client version remains 0.0.2+2; these fix the unresolved promotion review threads in #50.