Repository navigation
Bioc resub - #85
Merged
Merged
Bioc resub#85
Conversation
…style guide and updated function doc string
…_diff_ex.R` such differential expression results and SPE gene list are in the same order for merging. Also clarified comment in code explaining why we don't sort.
…og transformation only happens for non count based data
…nt analysis after fixes to calc_spatial_diff_ex.R
Imputation value writing was handled row by row in the proteomics data, which was incompatible with how Sample Minimum imputation data is calculated. Fixed imputed value assignment method for SampMin to fix that problem.
…nto bioc-resub
ymahlich
reviewed
Mar 11, 2026
Collaborator
There was a problem hiding this comment.
I am unclear on the ##herr er hry yhr comment in line 5 but otherwise this looks good
6 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the required feature requested by #82.