Skip to content

fix(release): support unsigned macOS builds - #414

Merged
AJenbo merged 1 commit into
PHPantom-dev:mainfrom
sidux:fix/release-unsigned-macos
Sep 8, 2026
Merged

fix(release): support unsigned macOS builds#414
AJenbo merged 1 commit into
PHPantom-dev:mainfrom
sidux:fix/release-unsigned-macos

Conversation

@sidux

@sidux sidux commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • keep macOS signing and notarization enabled when the complete Apple credential set is available
  • package unsigned macOS binaries when release credentials are unavailable
  • make the unsigned fallback visible in the workflow log

Why

Forks cannot access the upstream repository's Apple signing secrets. The release matrix should still produce complete cross-platform artifacts there, while preserving the signed and notarized path for credentialed releases.

Validation

  • reproduced the failure in both macOS matrix jobs at certificate import
  • validated the workflow YAML
  • verified all signing, notarization, and cleanup steps use the shared credential guard
  • cargo clippy --fix --allow-dirty -- -D warnings
  • cargo fmt --check

@sidux
sidux force-pushed the fix/release-unsigned-macos branch from f492560 to e2524c2 Compare August 30, 2026 16:03
@AJenbo AJenbo added this to the Sprint 7 milestone Sep 8, 2026
Keep signing and notarization enabled when the complete Apple credential
set is available. Package unsigned macOS artifacts when credentials are
absent so release workflows remain usable from forks.
@AJenbo
AJenbo force-pushed the fix/release-unsigned-macos branch from e2524c2 to 6639b7f Compare September 8, 2026 01:04
@AJenbo
AJenbo merged commit 75e18e3 into PHPantom-dev:main Sep 8, 2026
8 checks passed
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants