Skip to content

fix(types): normalize nullable array shapes - #396

Merged
AJenbo merged 1 commit into
PHPantom-dev:mainfrom
sidux:fix/nullable-array-shape-normalization
Sep 8, 2026
Merged

fix(types): normalize nullable array shapes#396
AJenbo merged 1 commit into
PHPantom-dev:mainfrom
sidux:fix/nullable-array-shape-normalization

Conversation

@sidux

@sidux sidux commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Why

Equivalent nullable array-shape spellings could survive as separate union members. Repeated control-flow joins then multiplied those equivalent variants, increasing type size and making workspace diagnostics progressively more expensive.

Summary

  • normalize nullable array shapes before union insertion
  • flatten and deduplicate equivalent nullable variants during joins
  • cover repeated shape merges with a regression test

Validation

  • cargo clippy --all-targets -- -D warnings
  • cargo test: 14,092 passed; 12 ignored

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@AJenbo AJenbo added this to the Sprint 7 milestone Sep 8, 2026
Treat union-with-null and nullable wrappers as the same shape during
repeated branch merges.
@AJenbo
AJenbo force-pushed the fix/nullable-array-shape-normalization branch from 8d96264 to 317b54b Compare September 8, 2026 00:56
@AJenbo
AJenbo merged commit fa7f031 into PHPantom-dev:main Sep 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants