Repository navigation
Fix recorder re-entry and atomic trace buffer delivery - #142
Merged
Merged
Conversation
This was referenced Oct 25, 2026
Essoz
changed the base branch from
daniel/parallel-infer
to
codex/parallel-infer-integration
October 26, 2026 08:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recorder-owned conversion and encoding could re-enter instrumented APIs, producing extra records or recursion. Concurrent buffer flushes could emit the same batch twice or clear a newly appended record before delivery.
Use an exception-safe thread-local suppression depth around recorder work, releasing it for application calls and generator execution. Keep mutable snapshots synchronous and lock buffer append, queue handoff, and clear. The class context manager also preserves frozen framework exceptions.
Controlled measurements using the actual wrapper/buffer implementations:
These are forced triggers, not occurrence-rate estimates. All 45 ordinary-tensor workload runs completed; the 36 instrumented MNIST/Transformer/DCGAN runs showed no trace-size change, and recorded losses/final model-state hashes matched their baselines. No general performance improvement or invariant-checking overhead claim is made.
Validation: 11 trace-integrity regression tests and repository-pinned Ruff, Mypy, Black, and isort hooks. The tests preserve nested application calls, generator calls, exception identity, real tensor snapshots, thread-local suppression, and buffer delivery order.
docs/experiments/trace-integrity.mdand its compact JSON retain scope, counts, runtime settings, and evidence hashes.Engineering hardening
Typed per-thread suppression state, context-manager exception/traceback handling and
Literal[False]exit results, plus queue/buffer/record contracts (aba4ee8). Four additional tests cover independent threads, exception restoration, enqueue-failure retention, and serialization failure. All 15 tracing tests and pinned hooks pass; stronger Mypy 1.9 checks cover the new contract tests. Legacy serializer/proxy bodies remain outside a full strict-typing migration.Separately composed updated production sources pass 140 affected Linux regression tests, whole-source Mypy (77 files), Ruff, and isort. Whole-source Black still reports three unchanged legacy files, down from six in the original base; changed-file hooks pass. Strict checks are scoped and do not establish repository-wide strict typing. Historical performance numbers above retain their original measured revisions; this hardening pass does not re-estimate them.
Integration with current main
Based on #150 (
codex/parallel-infer-integration), with signed merge checkpoint094182d5112c. The shared base is #150, which reconciles Daniel's parallel-inference tip122e769with mained54c7d. History is preserved; no force push or GitHub PR merge was used. The overlapping import conflict retains this PR's complete typed suppression implementation and the upstream shutdown guard. All nine PR heads merge cleanly with their declared bases and current main, and the full stack composes without conflicts.The resolved composition passes 140 production + 28 harness tests locally (Python 3.10.16 / Torch 2.2.2), pinned Mypy over 77 production files, and stricter Mypy over 9 harness/test files. Conflict-file commit hooks pass. Full-stack Ruff/Mypy/isort pass; Black retains the same three pre-existing formatting failures (
config.py,proxy_wrapper/hash.py,proxy_wrapper/subclass.py). Remote CI is ignored because the self-hosted runner is unavailable. These checks validate integration; existing performance measurements retain their original revisions and are not remeasured here.Land the parent in main first, then retarget this PR to main before merging it. Repeat for its children. Use merge commits to preserve stack ancestry, or refresh descendants after a squash/rebase merge. Exact heads and local logs are retained in
outputs/conflict-resolution-20261026/.