Repository navigation
fix(alarm): start unknown, restore the last state and poll *#5*0## unless the OWNd profile refuses it #803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
gdluck
wants to merge
6
commits into
OpenWebNet-HA:v2-phase1-architecture
from
gdluck:fix/alarm-unknown-restore
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5464597
fix(alarm): start unknown, restore the last state and skip *#5*0## wh…
ffd6290
fix(alarm): poll *#5*0## unless the OWNd profile says the gateway ref…
83854fc
fix(alarm): decide the *#5*0## skip on the gateway that carries the r…
fd8f71c
fix(alarm): restore only the states the panel emits and keep them unt…
9e55fb6
docs(alarm): say when the template panel is available after a restart
3b6b1bc
chore(alarm): drop the misattributed #177 references
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AlarmControlPanelState(last_state.state)accepts every HA core enum value (includingarmed_home, which MyHOME removed in#609, as well asarming/pending). Restoring a stalearmed_homefrom.storage/core.restore_statewould leave the documented template panel (states(...) in ['disarmed', 'armed_away', 'triggered']) stuckunavailable.Please restrict restoration to the states this entity actually emits (
{STATE_DISARMED, STATE_ARMED_AWAY, STATE_TRIGGERED}).