Repository navigation
[WebOverlay] Enhance session management and debug logging for web layer visibility - #1385
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the management of GPU memory and texture cache in relation to the web overlay (browser) layer. The main changes ensure that the system proactively frees up GPU resources as soon as the browser session starts, not just when the web layer becomes visible. This helps prevent memory exhaustion issues when the browser is loading, even before it's displayed.
Key changes include:
Web overlay session tracking and notification:
m_session_opento track when the browser (producer) session is active, and a newsessionOpen()method to expose this state. The callback for freeing textures (m_on_show) is now triggered both when the session starts (frame file mapped) and when the layer becomes visible, ensuring GPU memory is freed in both cases. [1] [2] [3]m_session_openwhen the browser session ends, such as when the shared memory file is unmapped or the producer process is gone. [1] [2]Texture cache management and logging: