Repository navigation
[IPTV] Improve handling of IPTV service entries and optimize default entry management - #1383
Merged
Merged
Conversation
…ntegration Add web overlay to the grab rendering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors and improves the IPTV service cache handling in the DVB and MP3 service code. The changes focus on making the cache more robust by preventing unnecessary or default entries from being stored, improving file read/write reliability, and clarifying the logic for handling service references and PIDs.
IPTV service cache and file handling improvements:
isDefault()method toeIPTVDBItemto identify entries that only contain default ("auto") audio/subtitle PIDs, and updated logic to avoid storing or persisting these default entries. [1] [2] [3]eDVBDBto split PID columns from the end of each line, improving robustness and removing legacy parsing code. The file is now written atomically using a temporary file andrename(). [1] [2]Service reference and PID matching:
s_refis not empty before using it infind()comparisons throughout the code, preventing invalid matches and potential errors. [1] [2] [3] [4]eServiceMP3::setCacheEntry, treat the first audio track (pid==0) as "auto" (-1), and avoid storing entries for this default. [1] [2]General code improvements:
<algorithm>include for use ofstd::remove_if.These changes together ensure that only meaningful, non-default IPTV service cache entries are kept in memory and persisted, reducing file bloat and improving cache accuracy.