Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The crawler could exit before its existing Nutch empty-fetch-list handler, or inject seeds after a failed sitemap download. Capture generate status before errexit; preserve the intended normal-empty and unexpected-error handlers. Retrieve sitemap seeds into a temporary file with HTTP failure detection, connection/overall time limits and pipeline failure propagation, reject empty or unsupported lines, then atomically replace the accepted seed file. Failures stop before injection and retain previous seeds.
Seven offline tests execute the real shell against temporary Nutch/curl stubs. Coverage includes two normal batches, empty fetch lists, unexpected generate errors, failures at every later pipeline stage, accepted sitemap replacement, partial/error downloads, empty/error bodies and unsupported compact XML. All pass locally; Bash syntax/diff checks pass. Ubuntu push/PR CI runs the same checks. The initial source reproduces both bypassed generate handlers.
The existing sitemap extractor still requires standalone loc lines and does not decode XML entities or traverse sitemap indexes. This change rejects unsupported line formats; it is not a general XML parser replacement.
No crawler/index has been deployed or invoked. Live deployment revision, freshness, robots/draft exclusion, update/deletion/redirect behavior and runtime modernization remain separate production-readiness gates. The VEXXHOST VM currently has no search deployment; its current production operator/access has been requested.