Repository navigation
fix: the pointer stays over what scripts draw on the menus - #1330
Merged
Merged
Conversation
The front end's own screens and the in-game menus drew their pointer inside their own drawing, before the scripts drew over the screen, so a script that drew where the pointer was covered it. The rooms and a mod's screen already drew theirs after the scripts. Each screen now leaves the pointer out, and its driver draws it after the scripts' drawing (canvas.Canvas.drawPointer): the front end for each screen it shows, the rooms' driver for the menus over the rooms, and flight for the pause menu. The restart screen keeps its pointer at the screen's brightness and hides it once a choice is made. The pause menu keeps the settings screen it leaves until the next frame, so that frame's pointer can still be drawn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The front end's own screens and the in-game menus drew their pointer inside their own drawing, before the scripts drew over the screen. So a script that drew where the pointer was covered it. The rooms and a mod's screen already drew theirs after the scripts.
canvas.Canvas.drawPointer:Interface.drawPointer);PauseMenu.drawPointer).Restart.drawPointer).Checked with the tests, and a new test that the restart screen's pointer stops once a choice is made.
Closes #1171