jsonforms-renderers(spreadsheet)!: require id on formula config/result entries, persist derivations as an id-keyed map

[sthanikan2000]

Summary

Breaking change to x-evaluate/derivation results, done as one cohesive change now that the parse/process split (#31) has landed underneath it:

1. id is now a required string on both FormulaConfigEntry (the x-evaluate config) and FormulaResult (what evaluateExpressions returns per entry) — previously entries were matched only by array index/label.
   • evaluateExpressions itself (in expression.ts) is untouched in behavior — it still returns an array, in authored order; only its per-entry shape now guarantees an id.
   • All 19 x-evaluate entries in the spreadsheet dev fixture now carry an id.
   • Extracted describeFormulaError as a reusable export (pure refactor, no behavior change) — used by later PRs in this stack.
2. SpreadsheetControl's persisted derivations changes from FormulaResult[] to Record<id, DerivationResult>, written directly into processMatrix (the seam jsonforms-renderers(spreadsheet): separate spreadsheet matrix processing from parsing #31 introduced). This is the actual purpose id-required serves: a sibling field can address one specific derivation's value directly via a plain data-tree path (e.g. sales.derivations.total_sales.value), with no "find by id in an array" step needed anywhere.
   • The "Computed values" panel now iterates Object.entries(derivations) instead of the array, keyed by id.

These two changes are combined into a single PR (rather than split, as in an earlier iteration of this stack) because requiring id has no purpose in this codebase other than serving as this map's key — splitting them meant a followup PR would delete/replace code the first PR had just introduced. Combining them, on top of the already-extracted processMatrix, means the map-building logic is written exactly once, directly in its final home.

Test plan

• pnpm type-check and pnpm test pass
• pnpm run format:check passes
• Manually verified in the dev playground: re-uploaded the sample spreadsheet, confirmed "Computed values" still lists every entry correctly

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 97f88684-2fea-4c2f-8926-37c8fa6ed30e

📥 Commits

Reviewing files that changed from the base of the PR and between 9853559 and bc05d26.

📒 Files selected for processing (9)

• packages/jsonforms-renderers/dev/fixtures.ts
• packages/jsonforms-renderers/docs/spreadsheet-formulas.md
• packages/jsonforms-renderers/src/renderers/SpreadsheetControl.tsx
• packages/jsonforms-renderers/src/utils/spreadsheet/expression.test.ts
• packages/jsonforms-renderers/src/utils/spreadsheet/expression.ts
• packages/jsonforms-renderers/src/utils/spreadsheet/index.ts
• packages/jsonforms-renderers/src/utils/spreadsheet/process.test.ts
• packages/jsonforms-renderers/src/utils/spreadsheet/process.ts
• packages/jsonforms-renderers/src/utils/spreadsheet/types.ts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}