Repository navigation
fix(config): Bridge still starts when it can't save the downloaded game list - #119
Merged
Merged
Conversation
…me list A failed save of the fetched game catalog no longer aborts startup. The catalog is still used for this run and written with the next settings change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
github-actions
Bot
added
type: bug
HighestFidelity
added a commit
to HighestFidelity/OpenMouse-Bridge
that referenced
this pull request
Nov 13, 2026
-OpenMouse-Project#119) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At startup Bridge fetches the game catalog and, when it changed, saves it to config.json. That save used
?, so if config.json couldn't be written (read-only file, full disk, a sync tool holding a lock),load_with_catalogfailed and Bridge didn't start at all, even though it had a perfectly good catalog in memory.What changed:
apply_fetched_catalog(normalizes the games, saves only when they changed). The "catalog unavailable" log moved intolog_catalog_unavailable. Same messages as before.Tested:
a_catalog_that_cannot_be_saved_is_still_used(save forced to fail, catalog still applied) andan_unchanged_catalog_is_not_saved_again(same games in another order and case write nothing; a new game is saved).cargo fmt --check,cargo test --locked, and clippy with-D warningsfor Linux and x86_64-pc-windows-gnu all pass.🤖 Generated with Claude Code