[cursor]

Summary

Adds regression tests for production code paths changed in Case aware application (#151) and the json-export CI progress fix (c7e573d1d), where behavior was updated but coverage was thin or missing.

Risky behavior now covered

• KOTOR install detection (is_kotor_install_dir) across cli_utils, patching, and diff/engine — case-mismatched chitin.key and install root paths must still resolve correctly on case-sensitive filesystems.
• Diff CLI path normalization (normalize_path_arg) — quoted paths, trailing slashes, and malformed paste input must not corrupt install paths.
• CaseAwarePath directory cache & ambiguous matching — cache reuse, cache clearing, and tie-breaking when multiple case variants exist.
• Indoor kit loading — kits directory with mismatched casing must still load via CaseAwarePath.
• Installation fixture layout — create_installation must emit Modules/ (not lowercase modules), matching real KotOR installs.
• TSLPatcher INI resolution — ConfigReader.from_filepath must resolve case-mismatched mod directory paths.
• JSON export progress in CI — _supports_live_progress must disable live \r updates when CI or GITHUB_ACTIONS is set so log aggregators capture percentage milestones.

Test files added/updated

File	Change
Libraries/PyKotor/tests/diff_tool/test_cli_utils.py	New — normalize_path_arg + install detection
Libraries/PyKotor/tests/common/test_is_kotor_install_dir.py	New — cross-implementation parity
Libraries/PyKotor/tests/common/test_case_aware_path_cache.py	New — cache + ambiguous match selection
Libraries/PyKotor/tests/test_indoorkit_case_path.py	New — case-mismatched kits directory
Libraries/PyKotor/tests/cli/test_json_commands.py	CI env guard for live progress
Libraries/PyKotor/tests/extract/test_installation.py	Modules/ directory casing assertion
Libraries/PyKotor/tests/tslpatcher/test_reader.py	case-mismatched INI path resolution

Why these tests materially reduce regression risk

These paths sit on high-blast-radius entry points: detecting game installs, resolving mod INI files, loading indoor kits, and exporting installation JSON in CI. A regression in any of them surfaces as silent mis-detection (wrong install), failed mod loads, or missing CI logs — not as an obvious crash. The tests are deterministic, use temp directories, and skip Windows-only case semantics where appropriate.

Validation

cd Libraries/PyKotor && uv run pytest --import-mode=importlib -m "not gui and not slow" \
  tests/diff_tool/test_cli_utils.py \
  tests/common/test_is_kotor_install_dir.py \
  tests/common/test_case_aware_path_cache.py \
  tests/test_indoorkit_case_path.py \
  tests/cli/test_json_commands.py::test_supports_live_progress_disabled_in_ci_env \
  tests/cli/test_json_commands.py::test_supports_live_progress_follows_tty_when_not_in_ci \
  tests/extract/test_installation.py::TestInstallation::test_create_installation_uses_modules_directory_casing \
  tests/tslpatcher/test_reader.py::TestConfigReaderFromFilepath::test_from_filepath_resolves_case_mismatched_mod_directory

35 passed (34 + 1 reader test).

  

[github-actions]

Message that will be displayed on users' first pull request

[github-actions]

🔨 Build Validation Summary

✅ Version Check: Passed

Tool Builds

⚠️ HoloPatcher: cancelled
⚠️ HoloPazaak: cancelled
⚠️ HolocronToolset: cancelled
⚠️ KotorDiff: cancelled
⚠️ KotorMCP: cancelled

---

🎉 All builds validated successfully! This PR is ready for merge.