Repository navigation
test: add regression coverage for case-aware install detection and CI progress - #327
Closed
cursor[bot] wants to merge 3 commits into
Closed
cursor[bot] wants to merge 3 commits into
cursor[bot] wants to merge 3 commits into
Conversation
Co-authored-by: PuritanWizard <th3w1zard1@users.noreply.github.com>
Co-authored-by: PuritanWizard <th3w1zard1@users.noreply.github.com>
Co-authored-by: PuritanWizard <th3w1zard1@users.noreply.github.com>
Contributor
|
Message that will be displayed on users' first pull request |
github-actions
Bot
added
python
Contributor
🔨 Build Validation Summary✅ Version Check: Passed Tool Builds
🎉 All builds validated successfully! This PR is ready for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risky behavior now covered
is_kotor_install_dir(diff CLI, patching CLI, tslpatcher diff engine): case-insensitivechitin.keyand install-root detection on POSIX — regression risk from Case aware application (Case-aware application #151)._supports_live_progress: disables live\rprogress whenCIorGITHUB_ACTIONSis set, ensuring percentage milestones reach log aggregators in automation.create_installationlayout: asserts canonicalModules/directory casing (not lowercasemodules/), matchingInstallation._find_resource_folderpath("Modules").ConfigReader.from_filepath: resolves case-mismatched mod directory and INI filename viaCaseAwarePath.Test files added/updated
Libraries/PyKotor/tests/common/test_is_kotor_install_dir.py(new)Libraries/PyKotor/tests/cli/test_json_commands.pyLibraries/PyKotor/tests/extract/test_installation.pyLibraries/PyKotor/tests/tslpatcher/test_reader.pyWhy these tests materially reduce regression risk
These paths gate core workflows: detecting valid KotOR installs for diff/patch tools, loading TSLPatcher INIs from mod folders, and exporting installation JSON in CI. Case mismatches on Linux/macOS previously caused silent failures; the CI progress guard prevents log-only regressions in GitHub Actions. All 16 new/parametrized tests pass locally.