Skip to content

docs(codereview): require design context for deep PRs - #550

Draft
enyst wants to merge 1 commit into
mainfrom
docs/deep-pr-design-context
Draft

docs(codereview): require design context for deep PRs#550
enyst wants to merge 1 commit into
mainfrom
docs/deep-pr-design-context

Conversation

@enyst

@enyst enyst commented Sep 11, 2026

Copy link
Copy Markdown
Member
  • A human has tested these changes.

Why

The extensions repository has the .pr/ artifact workflow but no repository-specific guidance for when deep, high-risk changes need design context. This adds the same review expectation being proposed in the other main repositories while accounting for extensions-specific contracts and the absence of a repository-local pr-design-doc skill.

Summary

  • Define repository-owned signals for deep changes: skills, plugins, automations, integrations, manifest schemas, shared loading/validation, and cross-cutting migrations.
  • Scale missing-design-context handling by risk without treating line count as an automatic gate.
  • Define the minimum content for an equivalent durable PR-description write-up.
  • Prevent automated approval from deleting the only .pr/ design artifact before a human maintainer reviews it.

Issue Number

Fixes #549

How to Test

Ran from the repository root:

git diff --check
grep -q '^triggers:' .agents/skills/custom-codereview-guide.md
grep -q 'temporary `.pr/` page' .agents/skills/custom-codereview-guide.md

All commands passed. This is a repository-local Markdown policy change with no runtime code path.

Video/Screenshots

Not applicable; there is no product UI change.

Notes

This deliberately does not claim .agents/skills/pr-design-doc/ exists in extensions. It allows any available design-doc artifact or an equivalent durable write-up and explicitly handles approval-triggered .pr/ cleanup.


This pull request was created by an AI agent (OpenHands) on behalf of @enyst.

@enyst can click here to continue refining the PR

Co-authored-by: openhands <openhands@all-hands.dev>
@github-actions github-actions Bot added the type: docs Documentation only changes label Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: docs Documentation only changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Define design-doc expectations for deep, high-risk PRs

1 participant