Repository navigation
Stop CETLVaSt from verifying the same commit twice (#267) - #268
Merged
Merged
Conversation
A full CETLVaSt run is 21 jobs and 260-370 job-minutes. Of the 16,405 job-minutes the last 100 runs used, 2,726 went to verifying a commit a second time and 4,185 to pull request runs that kept going after a newer commit was pushed. - Version tags no longer trigger the workflow. The release script waits for the main push run of the tagged commit and packages that run's bundle; nothing read the tag run. - The #verification and #docs commit-message triggers are gone. On a branch with an open pull request they ran the full matrix in the push run as well as the pull_request run. A manual dispatch verifies a branch without a pull request. - Full verification runs for pull requests, dispatches, and pushes to refs/heads/main, matched exactly. contains(github.ref, '/main') matched any ref containing /main, and pushes to an issue/* branch with an open pull request ran the matrix on both events. - A new commit cancels the running pull_request verification of its pull request. Runs on main are never cancelled because the release waits for them. - cache-warmup needs release-tests, so a release tooling failure stops the matrix instead of running it to a release-ready that must fail. The release contract tests follow the new conditions, and a new test keeps version tags out of the push trigger. CONTRIBUTING.md describes the triggers. Closes #267. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the CETLVaSt triggers that verified the same commit twice, and cancels superseded pull request runs (#267).
pushfilters onbranches: ["**"], so version tags do not trigger the workflow; the tag clause is gone from the job conditions.maincommit whosemainpush run the release already packaged#verification/#docscommit-message triggers removed.pull_requestrun on a branch with an open PRpull_request,workflow_dispatch, andgithub.ref == 'refs/heads/main'.contains(github.ref, '/main')substring matches;issue/*pushes with an open PRcancel-in-progress: ${{ github.event_name == 'pull_request' }}.mainruns are never cancelled.cache-warmupneedsrelease-tests.release-testsfailsThe 1,333 job-minutes from dispatching on a stacked PR that already had
pull_requestruns were a process error;CONTRIBUTING.mdnow says when to dispatch.Behaviour that changes for contributors: a push to an
issue/*branch, or a commit tagged#verification, no longer runs the full matrix by itself. PRs intomainorissue/*still do, and a maintainer can dispatch the workflow on any branch.Tests
test_full_release_gate_triggers_cover_all_dependenciesrecognisesgithub.ref == '...'predicates, so every gated job must carry themainclause.test_version_tags_reuse_the_main_run: thepushtrigger filters on branches only and the workflow never mentionsrefs/tags.test_matrix_and_gate_contract_matches_workflowis removed.Validation
python3 -m unittest discover -s scripts/tests: 83 tests pass.tags: ["v*"]underpushfailstest_version_tags_reuse_the_main_run; removing themainclause fromcache-warmupfails the trigger-coverage test.actionlintis clean. The parsed workflow has every gated job on the same three-term condition.node24); no bumps needed.pull_requestrun uses the new workflow.Closes #267.
🤖 Generated with Claude Code