Skip to content

Fix VLA bool shadow regression and enforce public-header diagnostics - #264

Merged
thirtytwobits merged 3 commits into
mainfrom
codex/issue-263-shadow-regression
Oct 25, 2026
Merged

thirtytwobits merged 3 commits into
mainfrom
codex/issue-263-shadow-regression

Conversation

@thirtytwobits

@thirtytwobits thirtytwobits commented Oct 25, 2026 •

Copy link
Copy Markdown
Member

Including cetl/pf17/cetlpf.hpp before variable_length_array.hpp makes GCC reject the packed-bool assignment implementation under -Wshadow -Werror: its local byte shadows cetl::byte. Rename the local to packed.

Enable -Wshadow throughout CETLVaSt and rename shadowed test parameters and fixture aliases. Add the reported bool pointer-range regression with the polyfill facade included first, so the existing assignment tests also exercise that namespace context.

Add 132 public-header compilation checks per configuration: each header alone, before and after each polyfill facade, and all headers together in forward and reverse order. Discover new headers automatically and require these checks through the existing build and unit-test targets. Keep translation units separate even when unity builds or precompiled headers are enabled.

Validation:

  • Confirmed the new assignment test and both facade-first VLA header checks fail on the original code.
  • Full GCC C++14 and Clang/libc++ C++20 debug suites passed, including examples and compile-failure tests, in the CI toolshed image.
  • Header and assignment checks passed under GCC C++14/17/20/23 in Release and DebugEP, GCC 7 C++14 in Release and DebugEP, and Clang/libc++ C++20 in DebugEP.
  • Full local GCC 7 C++14 and GCC C++17 Release suites, plus GCC 13 C++14 Release and Debug suites, passed.
  • CETLVaSt CI passed all 15 compiler/standard jobs and the release gate, including documentation and packaged-header consumer checks.
  • Local formatting checks and git diff --check passed.

Fixes #263.

@thirtytwobits

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T01:15:07.942008Z 47b2f4d Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 47b2f4d8a7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@thirtytwobits
thirtytwobits merged commit 94841a7 into main Oct 25, 2026
36 checks passed
@thirtytwobits
thirtytwobits deleted the codex/issue-263-shadow-regression branch October 25, 2026 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

variable_length_array<bool>: local 'byte' shadows cetl::byte, breaking GCC -Wshadow -Werror builds (v2.0.0)

1 participant