Repository navigation
Fix VLA bool shadow regression and enforce public-header diagnostics - #264
Merged
Merged
Conversation
Member
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Including
cetl/pf17/cetlpf.hppbeforevariable_length_array.hppmakes GCC reject the packed-bool assignment implementation under-Wshadow -Werror: its localbyteshadowscetl::byte. Rename the local topacked.Enable
-Wshadowthroughout CETLVaSt and rename shadowed test parameters and fixture aliases. Add the reported bool pointer-range regression with the polyfill facade included first, so the existing assignment tests also exercise that namespace context.Add 132 public-header compilation checks per configuration: each header alone, before and after each polyfill facade, and all headers together in forward and reverse order. Discover new headers automatically and require these checks through the existing build and unit-test targets. Keep translation units separate even when unity builds or precompiled headers are enabled.
Validation:
git diff --checkpassed.Fixes #263.