Repository navigation
Play upload: drop the Bluetooth plugin's capped location permissions, fail on rejection - #273
Merged
Merged
Conversation
… fail on rejection Google Play rejected the v0.13.0 staging bundle: the ble-plx plugin with neverForLocation declares ACCESS_COARSE/FINE_LOCATION again as uses-permission-sdk-23 with maxSdkVersion 30, next to the app's own uncapped declarations. withUncappedLocation removes the capped copies. The rejection went unnoticed because the upload step piped into tee and took its exit code; set -o pipefail makes a rejected upload fail the run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.13.0 Staging · Update built and "uploaded" the staging app, but Google Play still shows 0.11.0.
What went wrong
Duplicate declarations of <uses-permission> element 'android.permission.ACCESS_COARSE_LOCATION' in manifest with different maxSdkVersions.@sfourdrinier/react-native-ble-plx(lights Lights 1: fixtures foundation, Worker sync, BLE link and pairing #208) withneverForLocation: truedeclares both location permissions again asuses-permission-sdk-23capped atmaxSdkVersion 30, next to the app's own uncapped declarations (app.json, expo-location). v0.12.0 was the last bundle before the plugin and uploaded fine; every bundle since would be rejected, production included.tee, so the step tooktee's exit code.Fix
withUncappedLocationinapps/mobile/app.config.tsremoves the capped copies; Bluetooth scanning keepsneverForLocation.set -o pipefailin the upload step ofbuild-phone-app.yml: a rejected upload now fails the run.Checked
expo config --type introspect(production and staging): before, twouses-permission-sdk-23location entries withmaxSdkVersion 30; after, each location permission once, uncapped.make checkgreen.🤖 Generated with Claude Code