You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Node SDK readers reach signup without a channel tag, obscuring this acquisition path. Add utm_source=node_sdk&utm_medium=sdk to the README signup link; the shared source name is accurate for both GitHub and the npm README.
The live signup URL returns HTTP 200 and retains both query parameters. The current website signup source captures first-touch attribution and includes it in the signup payload; an actual signup and production attribution have not been tested. npm run storefront:check passed (40 public surfaces), and git diff --check passed.
Part of OilpriceAPI/oilpriceapi-api#9169. Other SDKs and end-to-end attribution still need verification.
Adversarial review of exact head 5f627e5: APPROVE for this README-only change.
The diff changes only the existing signup link, using node_sdk rather than claiming a GitHub or npm source for a README shared by both. The live signup URL returns HTTP 200 with both query parameters retained. Current website signup source captures first-touch parameters and adds them to the signup payload, but this review does not claim a production signup or a measurable acquisition result. npm run storefront:check passed on 40 surfaces and git diff --check passed. No API, package code, pricing or customer data is changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
risk:elevatedElevated: auto-merges after an adversarial review APPROVE
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node SDK readers reach signup without a channel tag, obscuring this acquisition path. Add
utm_source=node_sdk&utm_medium=sdkto the README signup link; the shared source name is accurate for both GitHub and the npm README.The live signup URL returns HTTP 200 and retains both query parameters. The current website signup source captures first-touch attribution and includes it in the signup payload; an actual signup and production attribution have not been tested.
npm run storefront:checkpassed (40 public surfaces), andgit diff --checkpassed.Part of OilpriceAPI/oilpriceapi-api#9169. Other SDKs and end-to-end attribution still need verification.