Repository navigation
Pin the release signing key and add a no-publish signing check - #538
Merged
Merged
Conversation
The release tag step now refuses a signing key whose fingerprint is not the configured release key and confirms the tag's signer after signing. A manually dispatched workflow exercises the same path without publishing: it signs and verifies a placeholder tag on the runner and deletes it, then runs JReleaser's Maven Central deployer in dry-run mode with placeholder Central credentials, which signs every staged artifact but uploads nothing, and checks each signature against the pinned fingerprint. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Future releases are signed with a dedicated release key (fingerprint
F6109A4F3F5616E1A7A62099E02DB03BAF6C438C), which is now in the repository's GPG secrets. This PR pins that key and adds a way to test signing without publishing.scripts/sign-release-tag.shrequiresEXPECTED_GPG_FINGERPRINT. It refuses a public or secret key with any other fingerprint, and after signing it checks the tag'sVALIDSIGsigner. A newverifymode signs and verifies the tag on the runner, then deletes it without pushing.release.ymlpasses the pinned fingerprint to the tag step.verify-release-signing.yml(manual dispatch,contents: read, no persisted checkout credentials):20000101.0and builds the staging repositoryrelease-20000101.0inverifymode (never pushed)jreleaser:deployin dry-run mode with placeholder Central credentials. JReleaser's Maven Central deployer signs every staged artifact and skips the upload in dry run, and the placeholder credentials could not publish anyway.scripts/verify-artifact-signatures.shrequires a.ascfor every staged artifact and checks that each was signed by the pinned fingerprint.jreleaser:signis not used for the check. With nofilesordistributionsconfigured it has nothing to sign: Maven Central artifacts are signed inside the deployer.Validation
git diff --checkpass.verifymode signs and verifies the tag and leaves none behind. It rejects a wrong expected fingerprint and an existing remote tag.The published 20261107.1 release is unchanged.
🤖 Generated with Claude Code