Skip to content

Pin the release signing key and add a no-publish signing check - #538

Merged
jmanico merged 1 commit into
mainfrom
verify-release-key-cutover
Nov 8, 2026
Merged

jmanico merged 1 commit into
mainfrom
verify-release-key-cutover

Conversation

@jmanico

@jmanico jmanico commented Nov 8, 2026

Copy link
Copy Markdown
Member

Summary

Future releases are signed with a dedicated release key (fingerprint F6109A4F3F5616E1A7A62099E02DB03BAF6C438C), which is now in the repository's GPG secrets. This PR pins that key and adds a way to test signing without publishing.

  • scripts/sign-release-tag.sh requires EXPECTED_GPG_FINGERPRINT. It refuses a public or secret key with any other fingerprint, and after signing it checks the tag's VALIDSIG signer. A new verify mode signs and verifies the tag on the runner, then deletes it without pushing.
  • release.yml passes the pinned fingerprint to the tag step.
  • New verify-release-signing.yml (manual dispatch, contents: read, no persisted checkout credentials):
    1. sets the runner's POMs to the placeholder version 20000101.0 and builds the staging repository
    2. signs and verifies release-20000101.0 in verify mode (never pushed)
    3. runs jreleaser:deploy in dry-run mode with placeholder Central credentials. JReleaser's Maven Central deployer signs every staged artifact and skips the upload in dry run, and the placeholder credentials could not publish anyway.
    4. scripts/verify-artifact-signatures.sh requires a .asc for every staged artifact and checks that each was signed by the pinned fingerprint.

jreleaser:sign is not used for the check. With no files or distributions configured it has nothing to sign: Maven Central artifacts are signed inside the deployer.

Validation

  • ShellCheck, actionlint, YAML parse, and git diff --check pass.
  • Both scripts were tested locally with throwaway keys.
    • The artifact verifier accepts good signatures. It rejects a tampered file, the wrong signer, a missing signature, a public key with the wrong fingerprint, and an empty repository.
    • The tag script's verify mode signs and verifies the tag and leaves none behind. It rejects a wrong expected fingerprint and an existing remote tag.
  • The Maven build and the real signing check run in CI. The workflow will be dispatched after merge.

The published 20261107.1 release is unchanged.

🤖 Generated with Claude Code

The release tag step now refuses a signing key whose fingerprint is not
the configured release key and confirms the tag's signer after signing.

A manually dispatched workflow exercises the same path without
publishing: it signs and verifies a placeholder tag on the runner and
deletes it, then runs JReleaser's Maven Central deployer in dry-run mode
with placeholder Central credentials, which signs every staged artifact
but uploads nothing, and checks each signature against the pinned
fingerprint.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jmanico
jmanico merged commit 205a3b9 into main Nov 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant