test(validation): cover @vocab suppressing the coverage finding - #137
Open
LukasGold wants to merge 1 commit into
Open
test(validation): cover @vocab suppressing the coverage finding#137LukasGold wants to merge 1 commit into
LukasGold wants to merge 1 commit into
Conversation
Contributor
Release previewNo version bump from the current commits (stays at Changelog preview (truncated)Preview via python-semantic-release and conventional commits. |
Contributor
📊 Benchmark ResultsClick to see benchmark comparisonThreshold: 1.3x (30% slower triggers a regression warning) Note: Benchmarks are informational only and won't fail the build. 💡 Tip: Download the |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the one demand in #120 that had no test behind it, and corrects two comments the
context.coveragesplit left stale.Changes
tests/data/oold/broken/vocab_covers_the_remainder.schema.json- new fixture. Byte-identical tomissing_context_term.schema.jsonapart from$id,title, and one added@vocab, so the two are each other's control.test_vocab_suppresses_the_coverage_finding- assertscontext.coveragestaysOK, and thatcontext.predicatesreportsmapped: 2, which is what proves@vocabmappedorphanrather than the check simply standing down.check_registry.py- the comment above thecontext.coverageCheckInfoopened "Deliberately cites no rule" three lines aboverule="OOLD-SCH-21d7".test_pipeline.py- the same claim in the docstring oftest_missing_context_term_warns_and_names_the_orphan_property.Why it matters
#120 (comment) required that the finding "must not fire at all when
@vocabis declared". That was confirmed by an ad-hoc probe before the split ofcontext.predicatesinto two checks, and never protected afterwards: no fixture in the corpus declared a@vocabat all, and the only@vocabin the suite asserted that the message text mentions it, which is a different claim. The permitted case was the one behaviour in that issue resting on nothing.No production behaviour changes. The only non-test edit is a comment.
Verification
make check: cleanuv run oold validate tests/data/oold --offline: PASS, 380 okParity
Green:
6 passedagainst a fresh clone ofoold-schemamain.An earlier revision of this description claimed parity was broken on
main. That was wrong and is retracted. Three parity tests did fail here, but the cause was a local~/.cache/oold/meta/remote-mainthat was 15 days old and still declaredx-oold-reverse-default-properties, removed upstream in OO-LD/oold-schema#152.oold meta fetch --forceturned all three green with no change to this repository.mainwas never broken and CI was never at risk, since a fresh runner has no cache.That the stale cache is silent is a real defect and is now #138. It is not this PR's to fix.
Refs #120. Does not close it: the severity question raised in #120 (comment) is still open.