Repository navigation
[16.0][IMP] webservice: do not override timeout - #193
Merged
Merged
Conversation
The requests adapters set the timeout to None on every call, discarding the one given by the caller. A call to a peer that accepts the connection but never answers then holds the worker until the peer closes the socket, which in a cron can block every other scheduled action for as long as the worker time limit allows. The timeout now travels in kwargs like any other requests parameter. Callers that pass none keep the previous behaviour, as requests defaults to no timeout.
Contributor
|
Hi @etobella, |
simahawk
approved these changes
Oct 29, 2026
Contributor
|
FTR timeout is now configurable by endpoint #175 |
Contributor
|
Another nice improvement on top the refactoring #188 |
AndreuOForgeFlow
approved these changes
Oct 29, 2026
MiquelRForgeFlow
approved these changes
Oct 29, 2026
Contributor
|
/ocabot merge patch |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
DavidJForgeFlow
approved these changes
Oct 29, 2026
This was referenced Oct 29, 2026
Contributor
|
Congratulations, your PR was merged at 1bc8d20. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The requests adapters set the timeout to None on every call, discarding the one given by the caller. A call to a peer that accepts the connection but never answers then holds the worker until the peer closes the socket, which in a cron can block every other scheduled action for as long as the worker time limit allows.
The timeout now travels in kwargs like any other requests parameter. Callers that pass none keep the previous behaviour, as requests defaults to no timeout.