Repository navigation
[FIX] endpoint_route_handler: scope registry mutation in tests - #187
Merged
OCA-git-bot merged 1 commit intoOct 20, 2026
Merged
OCA-git-bot merged 1 commit into
OCA-git-bot merged 1 commit into
Conversation
The mocked request set `registry._init_modules` to an empty set and never restored it. The registry is shared, so every routing map built afterwards dropped the controllers of all modules: tests of other modules (eg: `http_json_dispatcher`) got 404 on their routes when run in the same process. Patch it only for the duration of the mocked request.
OCA-git-bot
added
mod:endpoint_route_handler
Contributor
Author
|
/ocabot merge patch |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at 7576822. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #185 (18.0).
Motivation
The mocked request in
endpoint_route_handlertests setsregistry._init_modulesto an empty set and never restores it. The registry is shared, so every routing map built afterwards loses the controllers of all modules. Tests of other modules run in the same process then get 404 on their routes.Key changes
_init_modulesonly for the duration of the mocked request