Skip to content

[16.0] [FIX] fs_product_multi_image: Fix main_image_id on product.template and add image_128 - #652

Open
lmignon wants to merge 2 commits into
OCA:16.0from
acsone:16.0-fs-product-multi-image-128-lmi
Open

lmignon wants to merge 2 commits into
OCA:16.0from
acsone:16.0-fs-product-multi-image-128-lmi

Conversation

@lmignon

@lmignon lmignon commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@oca-cla-bot

oca-cla-bot Bot commented Aug 19, 2026 •

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@lmignon

lmignon commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

ping @rousseldenis @nicolas-delbovier-acsone Used in production for the last 2 months...

@nicolas-delbovier-acsone nicolas-delbovier-acsone left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Before this commit, the main_image_id field on product.template was not
being computed correctly, leading to incorrect image display in the
product views. This commit fixes the computation of main_image_id by
ensuring that it selects the correct image from the related image_ids.
…and product.template

This field is a compatibility field for standard modules (especially website_sale)
that expect to find an image_128 field on product.product and product.template
records. The sole purpose of this field is to provide the field image_128
that can be resolved by the web controller when requested to provide
the image_128 content of a product.product or product.template record.
@lmignon
lmignon force-pushed the 16.0-fs-product-multi-image-128-lmi branch from ffb5197 to fcac3eb Compare October 19, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants