Repository navigation
[19.0][FIX] spreadsheet_oca: Allow adding relational field columns and rows - #141
Conversation
christian-ramos-tecnativa
left a comment
christian-ramos-tecnativa
left a comment
There was a problem hiding this comment.
Functional review OK
|
Thanks for the improvement. It's working well, but it's provoking a side effect: the measures list is now taking the same dialog as the rows/column ones, while it should be a special one. Please check it. |
Before this changes we were not allowed to add childs of relational fields. Now is added the arrow to see the child fields of a relational field, which give the possibility to add these fields to the dynamic table. TT65182
5beeba4 to
57a702e
Compare
|
Change done @pedrobaeza |
| */ | ||
| class PivotFieldSelectorPopover extends ModelFieldSelectorPopover { | ||
| canFollowRelationFor(fieldDef) { | ||
| return fieldDef.type === "many2one" && fieldDef.groupable; |
There was a problem hiding this comment.
Why not including many2many as well?
There was a problem hiding this comment.
The ORM only accepts many2one fields to traverse a groupby path (_read_group_groupby raises "Only many2one path is accepted" otherwise), as grouping through a x2many would duplicate rows and break the aggregates. Many2many fields can still be used directly as dimensions, just not followed.
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 57a2269. Thanks a lot for contributing to OCA. ❤️ |
Before this changes we were not allowed to add childs of relational fields.
Now is added the arrow to see the child fields of a relational field, which give the possibility to add these fields to the dynamic table.
cc @Tecnativa TT65182
ping @pedrobaeza @christian-ramos-tecnativa