Repository navigation
[19.0][FIX] fastapi: pool apps by endpoint root path, not request path - #677
Open
SparkDrago05 wants to merge 1 commit into
Open
SparkDrago05 wants to merge 1 commit into
SparkDrago05 wants to merge 1 commit into
Conversation
FastApiDispatcher passed the full request path as the key of the app pool. Every distinct path under an endpoint, including unknown paths and path parameters, built and kept its own FastAPI application until the registry cache was invalidated, so worker memory grew with the number of distinct paths requested, even unauthenticated ones. Resolve the endpoint's root path once per request and use it as the pool key and for the uid lookup. Fixes OCA#656 Assisted-by: Claude Opus 5.5 Signed-off-by: SparkDrago05 <huzaifa.farooq05@gmail.com>
Contributor
|
Hi @lmignon, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward port of #670 (approved on 18.0). Fixes #656.
The app pool was keyed on the full request path, so every distinct URL built and kept its own FastAPI app. It is now keyed on the endpoint's root path.
Tested on 19.0 with the steps from the issue (53 requests): 51 apps kept before, 1 after. A new test covers it, and the
fastapitests pass (25/25).Assisted-by: Claude Opus 5.5