Repository navigation
[18.0][FIX] test-requirements: pin pydantic<2.14 - #671
Closed
SparkDrago05 wants to merge 1 commit into
Closed
SparkDrago05 wants to merge 1 commit into
SparkDrago05 wants to merge 1 commit into
Conversation
extendable-pydantic uses pydantic._internal._generate_schema.get_type_ref, which pydantic 2.14 removed, so the test jobs fail on every 18.0 PR. Same fix as OCA/server-auth#1045. Assisted-by: Claude Opus 5.5 Signed-off-by: SparkDrago05 <huzaifa.farooq05@gmail.com>
Contributor
|
A fix is on this way and is waiting approval/reviewers. Please test lmignon/extendable#19 and lmignon/extendable-pydantic#26? These changes fix the compatibility issue. |
Author
|
Thanks @lmignon, I tested both PRs together (extendable#19 at 46f6f55, extendable-pydantic#26 at ebc993c):
Looks good to me. |
Contributor
Thank you for the tests. I already know that all the tests passed on odoo16 and odoo18. 😏 My main concern is ensuring that these changes don't introduce unexpected behavior in deployments other than my own. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test jobs fail on every 18.0 PR (e.g. #660, #662, #670):
extendable-pydanticusespydantic._internal._generate_schema.get_type_ref, which pydantic 2.14 removed.This pins
pydantic<2.14intest-requirements.txt, like OCA/server-auth#1045. Checked in a clean venv: with pydantic 2.14.1import extendable_pydanticfails, with 2.13.5 it works.Assisted-by: Claude Opus 5.5