Skip to content

[18.0][FIX] test-requirements: pin pydantic<2.14 - #671

Closed
SparkDrago05 wants to merge 1 commit into
OCA:18.0from
SparkDrago05:18.0-test-pin-pydantic
Closed

SparkDrago05 wants to merge 1 commit into
OCA:18.0from
SparkDrago05:18.0-test-pin-pydantic

Conversation

@SparkDrago05

Copy link
Copy Markdown

The test jobs fail on every 18.0 PR (e.g. #660, #662, #670): extendable-pydantic uses pydantic._internal._generate_schema.get_type_ref, which pydantic 2.14 removed.

This pins pydantic<2.14 in test-requirements.txt, like OCA/server-auth#1045. Checked in a clean venv: with pydantic 2.14.1 import extendable_pydantic fails, with 2.13.5 it works.

Assisted-by: Claude Opus 5.5

extendable-pydantic uses pydantic._internal._generate_schema.get_type_ref,
which pydantic 2.14 removed, so the test jobs fail on every 18.0 PR.
Same fix as OCA/server-auth#1045.

Assisted-by: Claude Opus 5.5
Signed-off-by: SparkDrago05 <huzaifa.farooq05@gmail.com>
@lmignon

lmignon commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

A fix is on this way and is waiting approval/reviewers. Please test lmignon/extendable#19 and lmignon/extendable-pydantic#26? These changes fix the compatibility issue.

@lmignon lmignon closed this Oct 22, 2026
@SparkDrago05

Copy link
Copy Markdown
Author

Thanks @lmignon, I tested both PRs together (extendable#19 at 46f6f55, extendable-pydantic#26 at ebc993c):

  • extendable-pydantic tests: 30 passed, and extendable tests: 23 passed. Each on pydantic 2.14.1 and 2.13.5, with Python 3.12 and 3.14.
  • Odoo 18.0 (official image) with pydantic 2.14.1 and both branches installed: rest-framework 18.0 (5538e36) pydantic, extendable_fastapi and fastapi tests (with extendable installed) give 0 failed, 0 error(s) of 43 tests. No get_type_ref error.

Looks good to me.

@lmignon

lmignon commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Thanks @lmignon, I tested both PRs together (extendable#19 at 46f6f55, extendable-pydantic#26 at ebc993c):

  • extendable-pydantic tests: 30 passed, and extendable tests: 23 passed. Each on pydantic 2.14.1 and 2.13.5, with Python 3.12 and 3.14.
  • Odoo 18.0 (official image) with pydantic 2.14.1 and both branches installed: rest-framework 18.0 (5538e36) pydantic, extendable_fastapi and fastapi tests (with extendable installed) give 0 failed, 0 error(s) of 43 tests. No get_type_ref error.

Looks good to me.

Thank you for the tests. I already know that all the tests passed on odoo16 and odoo18. 😏 My main concern is ensuring that these changes don't introduce unexpected behavior in deployments other than my own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants