Skip to content

[20.0][MIG] account_credit_control - #586

Open
MiquelRForgeFlow wants to merge 138 commits into
OCA:20.0from
ForgeFlow:20.0-mig-account_credit_control
Open

MiquelRForgeFlow wants to merge 138 commits into
OCA:20.0from
ForgeFlow:20.0-mig-account_credit_control

Conversation

@MiquelRForgeFlow

Copy link
Copy Markdown
Contributor

.

@OCA-git-bot OCA-git-bot added mod:account_credit_control Module account_credit_control series:20.0 labels Oct 20, 2026
@juanalfonsocb

Copy link
Copy Markdown

#591 Include this commit, please.

@ and others added 26 commits October 27, 2026 12:55
* Modify scenarios to be compatible with python scenarios
* Voucher/statement related steps
* Deprecated step implementation
* Print report generation
* All tests green
* Mail + print of reminder
* Broken translations
* Fix failure to confirm invoice when both account_credit_control  and account_constraints are installed
* use except_orm instead of except_osv
* reindent code
* Cleanup
* use of deprecated field user_email causes permission error in multicompany setting fixed by using the correct 'email' field in the template
* Address in mako template to make sure address is displayed
* Remove 'more info here' from report
* Add some css to reminder report and set texts taking the whole width of the document
* Add a subject in reminder report
* Report use precise mode by default
* date_entry fields on line model to be used by report or in next MP on filter group by
* reporting layer, + add hook function to get contact address
* credit control mail are not in plain text but send as attachement
* policy level name is now translatable as it is use in report and mail
* permission on invoices because onetomany widget load data even if hidden ...
* translation files + lang source
* french translation
* Translation + report invoice address layout
* Label Force credit control policy + french translation
* pep8 (space after comma, reduced length of lines)
* does not need to check if there is ids before calling unlink, it will return early
* remove unused import
* 'raise a new invoice' is a British English expression for 'issue a new invoice'
* scenarios: We fix year of scenario on 2013 to have reproducable setup, and ensure test maintnability. The credit control scenarios are based on base_finance setup scenario provided in the project OpenERP Scenarios. This setup provide a financial setup for 2012 2013. We also fix some value as precision computation has been improved in OpenERP.
* bug 1287072 Level calculation error if previous credit line is ignored
* unifing wizard views to respect UI guide lines
* credit control policy changer. Add a wizard on Invoice that will add a credit line and deprecate exisiting one on the invoice
* test to ensure that wizard run on customer invoice
* Scenario that test coherence of credit run after manually altering an invoice level
* multicurrency in communication
* ...
* Partner Form view: field "credit_limit" is defined in account module, not base
* Minimal Danish translation
* Do not link e-mails to Transient records

Transient records are deleted periodically so res_id will point to ID which
does not exists. And when reading email records system would also check if
res_id can be read by user which would cause an exception because res_id
might not exist at that point.
This fix seems ugly, but I cant figure why I've a security error when an invoice is  displayed for a user without right on credit_control despite the attribute 'groups' declared on the field definition in the form view
sergio-teruel and others added 29 commits October 27, 2026 13:01
…the maximum level for one control run

Some ux improvements and minor fixes
Currently translated at 100.0% (280 of 280 strings)

Translation: credit-control-17.0/credit-control-17.0-account_credit_control
Translate-URL: https://translation.odoo-community.org/projects/credit-control-17-0/credit-control-17-0-account_credit_control/it/
…to auto-subscribe in credit control lines

TT55207
Currently translated at 100.0% (281 of 281 strings)

Translation: credit-control-17.0/credit-control-17.0-account_credit_control
Translate-URL: https://translation.odoo-community.org/projects/credit-control-17-0/credit-control-17-0-account_credit_control/it/
…ation email

Changes done:
- Defined date_entry for the Invoice date column.
- Define amount_due for Invoice amount column
- Set balance_due for the Amount Due column

This data is the same as already shown in the Credit Control Summary report.

TT55608
…nd in the report for correct visualization

TT55608
Currently translated at 100.0% (281 of 281 strings)

Translation: credit-control-18.0/credit-control-18.0-account_credit_control
Translate-URL: https://translation.odoo-community.org/projects/credit-control-18-0/credit-control-18-0-account_credit_control/it/
…as blacklisted

Before, if the contact email is balcklisted, the control lines just appear as "queued"
forever, even if the mail was canceled. This is due to postprocess not being called.
The root tag for the message could be a span in certain cases,
so these are excluded from the check.

The email_from is defined in the template, so it should be set on the
company to be able to send it.
…ckground"

This reverts commit 834e7ad.

Commit:
odoo/odoo@543a3ad

Contains the comment that
```
```

So a thread is generally assumed to take at most 2 cursors.
Because of this, it is essentially a very bad idea to open an unlimited number of cursors.
(On a decently sized DB, about 400 lines would be processed in parallel...)

Because things are launched in their own cursor, this doesn't impact the main request,
so the run is marked as done and all lines are marked as queued,
despite the emails never being scheduled.

There is already a way to manage this kind of cases in the OCA that is called `queue_job`.
Therefore this is the module that should handle this.

If for some reason one would still want the threaded code nonetheless,
it should be put in a custom project module, as it relies on some environment hypothesis
that can't be tested from within the code.

Note that one test is split into two; although it is better to avoid code duplication,
the test was cheating the setup, and therefore not representative of the real user flow is
when users click on the interface buttons.
…_control_queue_job initialized

Since tests first initialize modules then run the tests,
this module needs to pass the context key queue_job__no_delay
Currently translated at 74.0% (203 of 274 strings)

Translation: credit-control-18.0/credit-control-18.0-account_credit_control
Translate-URL: https://translation.odoo-community.org/projects/credit-control-18-0/credit-control-18-0-account_credit_control/fr/
Co-authored-by: Aaron ForgeFlow <aaron.henriquez@forgeflow.com>
Currently translated at 100.0% (274 of 274 strings)

Translation: credit-control-19.0/credit-control-19.0-account_credit_control
Translate-URL: https://translation.odoo-community.org/projects/credit-control-19-0/credit-control-19-0-account_credit_control/it/
Currently translated at 7.2% (20 of 274 strings)

Translation: credit-control-19.0/credit-control-19.0-account_credit_control
Translate-URL: https://translation.odoo-community.org/projects/credit-control-19-0/credit-control-19-0-account_credit_control/sl/
Currently translated at 100.0% (273 of 273 strings)

Translation: credit-control-19.0/credit-control-19.0-account_credit_control
Translate-URL: https://translation.odoo-community.org/projects/credit-control-19-0/credit-control-19-0-account_credit_control/sv/
Currently translated at 100.0% (273 of 273 strings)

Translation: credit-control-19.0/credit-control-19.0-account_credit_control
Translate-URL: https://translation.odoo-community.org/projects/credit-control-19-0/credit-control-19-0-account_credit_control/da/
@MiquelRForgeFlow
MiquelRForgeFlow force-pushed the 20.0-mig-account_credit_control branch from 05de2f8 to a220b8c Compare October 27, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:account_credit_control Module account_credit_control series:20.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.