Skip to content

Run the NosCore analyzers on this package - #154

Merged
erwan-joly merged 1 commit into
masterfrom
claude/project-thread-kzp23e
Nov 3, 2026
Merged

erwan-joly merged 1 commit into
masterfrom
claude/project-thread-kzp23e

Conversation

@erwan-joly

@erwan-joly erwan-joly commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #65. This adds NosCore.Analyzers 2.1.0 as a private build-time reference, the same way PathFinder and Archive already do. The package builds with no new warnings.


Generated by Claude Code

Summary by CodeRabbit

  • Chores
    • Updated internal project tooling configuration.

Fixes #65

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014gSmkW4H42dDTduM5qrKt2
@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

The project adds NosCore.Analyzers version 2.1.0 as a private package reference and specifies the included asset categories.

Changes

Analyzer package reference

Layer / File(s) Summary
Add analyzer package reference
src/NosCore.Algorithm/NosCore.Algorithm.csproj
The project references NosCore.Analyzers version 2.1.0, sets PrivateAssets to all, and includes the listed asset categories.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Merge Risk: Minimal · up to c31f6

No merge-blocking issue is identified in the analyzer-reference change; merge after normal build checks pass.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: enabling NosCore analyzers for the package.
Linked Issues check Passed Issue #65 directly requests adding NosCore.Analyzers. The pull request adds NosCore.Analyzers version 2.1.0 to src/NosCore.Algorithm/NosCore.Algorithm.csproj as a private build-time reference.…
Out of Scope Changes check Passed The change is limited to the project reference required by issue #65. The summary reports no changes to exported or public entities. No unrelated implementation change is identified.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Full details: Linked Issues check

Explanation

Issue #65 directly requests adding NosCore.Analyzers. The pull request adds NosCore.Analyzers version 2.1.0 to src/NosCore.Algorithm/NosCore.Algorithm.csproj as a private build-time reference. Issue #65 defines no additional coding requirements or test requirements.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 6386b7c and c31f64b.

Files selected for processing: 1
  • src/NosCore.Algorithm/NosCore.Algorithm.csproj

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@erwan-joly
erwan-joly merged commit d8a4745 into master Nov 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add NosCore.Analyzers

2 participants