Repository navigation
Replace the Azure pipeline with a GitHub Actions build - #8
Merged
Merged
Conversation
Builds the .NET Framework games with MSBuild, then builds and tests the .NET Core/5 solutions with the dotnet CLI, and drops azure-pipelines.yml. Claude-Session: https://claude.ai/code/session_01Nyppsn3VF6d1Sno5orPWiV
There was a problem hiding this comment.
🟡 Changes recommended
The workflow is expected to fail because .NET Framework 4.5 reference assemblies are unavailable on the runner.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Migrates CI from Azure Pipelines to GitHub Actions.
Changes:
- Adds a Windows workflow for restore, build, testing, and TRX artifacts.
- Removes the obsolete Azure Pipeline configuration.
File summaries
| File | Summary | Review status |
|---|---|---|
azure-pipelines.yml |
Removed obsolete Azure Pipeline. | No final comments |
.github/workflows/build.yml |
Defines the replacement build and test workflow. | Critical issue: .NET Framework 4.5 reference assemblies are not provisioned. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+39
to
+42
| - name: Build the .NET Framework games | ||
| run: | | ||
| nuget restore CSharpConsoleGames.sln | ||
| msbuild CSharpConsoleGames.sln -p:Configuration=Release -p:Platform="Any CPU" -m |
The hosted runners no longer carry the v4.5 targeting pack. Claude-Session: https://claude.ai/code/session_01Nyppsn3VF6d1Sno5orPWiV
PlayShouldReturnCorrectWinner compared a GameResult with a Symbol, so it could never pass; it was left behind when Play started returning GameResult. Claude-Session: https://claude.ai/code/session_01Nyppsn3VF6d1Sno5orPWiV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates CI from Azure Pipelines to GitHub Actions: builds and tests the solution in Release on windows-latest, and removes azure-pipelines.yml.
The Azure DevOps project behind the old pipeline is being deleted.