Repository navigation
[TUI] Add explicit host overrides to strata launch - #4207
Open
yuantianxiayouqingrenzhongchengxiongmei wants to merge 2 commits into
Open
yuantianxiayouqingrenzhongchengxiongmei wants to merge 2 commits into
yuantianxiayouqingrenzhongchengxiongmei wants to merge 2 commits into
Conversation
Carry the requested IPv4 bind address through launch presets, private run configs, profiles, status, Connect and monitoring. Preserve the existing access-mode binding when no host override is supplied.
yuantianxiayouqingrenzhongchengxiongmei
marked this pull request as draft
October 26, 2026 10:48
# Conflicts: # strata_cli/launch/cmd.py
yuantianxiayouqingrenzhongchengxiongmei
marked this pull request as ready for review
October 28, 2026 06:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strata launchexposes access mode and port but cannot select a particular local interface. This adds--host ADDRESSso, for example, a server can bind to192.168.1.20:8080directly from the launch command.The address follows the launch through presets, private run configuration, managed profiles, status, Connect and monitoring. It accepts IPv4 addresses and
localhost; a non-loopback address keeps the existing shared-access API-key policy. Wildcard bindings are never advertised as client destinations. Tunnel-incompatible binds are rejected before start.An omitted
--hostpreserves the existing access-mode bind defaults and serialized launch settings. Choosing--accesswithout--hostclears a saved host override. Local HTTP monitoring accepts addresses belonging to this computer and bypasses system proxies; other network peers still require HTTPS.Example:
Validation against upstream main
5e8a4cca(v0.2.7):Windows / Python 3.13.1: launch, launch TUI, monitor, connections, terminal, loopback, second-launch and DeepSeek context suites: 311 passed, 1 skipped, 1 failed in 187.26 seconds. All 26 host tests passed, including a shared host with the upstream DeepSeek pack context limit.
The only failure was
tests/terminal/test_launch_tui.py::FolderStep::test_default_folder_and_free_space_and_change(Noneinstead of an explicit data directory). It also fails at the same assertion on unmodified upstream5e8a4ccain the same environment. The full run reported three event-loop/thread warnings fromSaveAndRun::test_save_and_stop_here.Twenty synthetic cases without
--hostmatch upstream's serialized settings bytes, command flags, and derived configuration bytes.git diff --checkagainst upstream passed.IPv6 and arbitrary DNS bind names are outside this PR. GPU inference, macOS/Linux integration, and live Cloudflare/Tailscale tunnels were not tested on this revision; no inference speed change is claimed. This remains a draft for review.