Skip to content

zone: run disabled validation cases - #33

Merged
msimerson merged 1 commit into
NicTool:mainfrom
aberoham:library-zero-skips
Aug 30, 2026
Merged

zone: run disabled validation cases#33
msimerson merged 1 commit into
NicTool:mainfrom
aberoham:library-zero-skips

Conversation

@aberoham

Copy link
Copy Markdown
Contributor

Three test cases were disabled with it.skip because the validation they check was commented out. Running them meant deciding what the schemas should do.

zone applies .domain() again. Before this, a zone name was any string of 3 to 255 characters.

The commented-out rule on zone_record.owner went the other way. An owner is the left-hand name of a resource record, either relative to its zone (www) or fully qualified (www.example.com.). The rule was .hostname({ allowFullyQualified: false }), and it rejects 128 of the 143 distinct owner values in a populated database:

* , *.something , some.*.thing , 0 , 1 , 10 , 1.2.0.192.in-addr.arpa.

Wildcards, bare numeric labels in a reverse zone, and qualified owners are all ordinary. So owner gets a grammar built from what DNS allows. RFC 1035 labels, widened by the underscore labels of RFC 8552. The asterisk that RFC 4592 makes a wildcard in the leftmost label and a literal anywhere else. Labels cap at 63 characters and the name at 255.

Measured against the same database it accepts all 143. It still rejects a..b, a b, a/b, .leading, and an over-long label.

validate:  306 tests, 305 pass, 1 skipped
api:       mysql 404/404, json 381/381

The skip is the RR-fields check. It needs the dns-resource-record checkout beside this one.

@msimerson
msimerson merged commit 1876d0c into NicTool:main Aug 30, 2026
9 checks passed
@msimerson msimerson mentioned this pull request Aug 31, 2026
msimerson added a commit that referenced this pull request Aug 31, 2026
- zone: run 3 disabled validation cases (#33)
- id: keep ids server-owned (#34)
- user: accept an email at any syntax-valid domain (#32)
- zone: nameservers are nameserver ids (#31)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants