zone: run disabled validation cases - #33
Merged
Merged
Conversation
msimerson
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three test cases were disabled with
it.skipbecause the validation they check was commented out. Running them meant deciding what the schemas should do.zoneapplies.domain()again. Before this, a zone name was any string of 3 to 255 characters.The commented-out rule on
zone_record.ownerwent the other way. An owner is the left-hand name of a resource record, either relative to its zone (www) or fully qualified (www.example.com.). The rule was.hostname({ allowFullyQualified: false }), and it rejects 128 of the 143 distinct owner values in a populated database:Wildcards, bare numeric labels in a reverse zone, and qualified owners are all ordinary. So
ownergets a grammar built from what DNS allows. RFC 1035 labels, widened by the underscore labels of RFC 8552. The asterisk that RFC 4592 makes a wildcard in the leftmost label and a literal anywhere else. Labels cap at 63 characters and the name at 255.Measured against the same database it accepts all 143. It still rejects
a..b,a b,a/b,.leading, and an over-long label.The skip is the RR-fields check. It needs the dns-resource-record checkout beside this one.