user: accept an email at any domain - #32
Merged
Merged
Conversation
Joi's email() checks the TLD against its built-in list, so a user at an internal or reserved domain fails validation. The api validates its own responses with this schema, so such a user cannot log in: POST /session returns 500 on "user.email" must be a valid email. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RxcUNWRPrY7gKukije8hFC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
joi's
email()checks the TLD against its built-in list, so a user at an internal or reserved domain (.local,.corp,.test) fails validation. The api validates its own responses with this schema, so such a user can't log in:POST /sessionreturns 500.tlds: falsekeeps the syntax checks and drops the list. Found with a production copy whose anonymised emails live at.test.