zone: nameservers are nameserver ids - #31
Merged
Merged
Conversation
The api is gaining a write path for a zone's nameserver assignment, and the v2 GUI sends nameserver ids. Nothing consumed the string form. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RxcUNWRPrY7gKukije8hFC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The api is gaining a write path for a zone's nameserver assignment, and the v2 GUI sends nameserver ids, so
nameserverson the zone POST and PUT schemas is now an array of ids instead of strings. Nothing consumed the string form.This needs a release (or version bump) before it can be depended on: NicTool/api#61 will require it for the zone nameserver route, and NicTool/NicTool#365's bridge sends the ids (the remaining open Copilot thread there, on zone nameserver assignment).