create: keep ids server-owned - #70
Draft
aberoham wants to merge 1 commit into
Draft
Conversation
aberoham
force-pushed
the
reject-create-ids
branch
from
August 30, 2026 14:11
9f047aa to
481cc61
Compare
Contributor
|
I'm confined to a phone screen today, but if you checkout the subproject '.release" in the validate repo, and follow the README steps, it'll create a release PR which I can merge and will auto-release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
idforbidden on create (NicTool/validate#34), the file stores have to allocate their own.nextId()moves intolib/store/file.js. That also retires the two hand-rolled copies of the same reduce in the session and zone record stores. The mysql user store no longer looks up{id: undefined, gid}before every insert.Route coverage per entity. A create carrying an id is refused. A create without one allocates and returns it. A
PUTwith a route id still works.Draft until validate#34 merges. CI installs that PR's head from source, per the pattern in 7a64bad. When it merges,
NICTOOL_VALIDATE_SPECmoves to the merge commit. When it releases, the variable goes and the dependency bumps.coverage.ymlruns the shared NicTool/.github job and cannot take that variable, so coverage is red on the new tests until the release.Ticks "verify the API won't permit setting auto-increment fields" in #6. The
other two boxes there are untouched.