store: reject create conflicts - #69
Merged
Merged
Conversation
msimerson
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create()with an id that already existed returned the existing row. 201 Created, the caller's payload silently discarded, and a response body describing a record they never wrote.The short-circuit was deliberate: suites re-create fixtures by fixed id without cleaning up first. That's now something a caller asks for,
create(args, { ifExists: 'return' }), and only the test helpers ask. Everything else gets a 409.Every store has the pattern, mysql and file alike, so all of them changed and the backends still agree.
A second bug lives in the same lines and gets the same fix:
lib/permission/store/mysql.jsflattened the nested{user:{id}}payload after looking for an existing row, so two POSTs wrote twont_permrows.objectToDb()now runs first, and the check covers user rows as well as group rows.