WIP: Add fsGroup annotation to set UNIX group ownership on ONTAP NAS volumes - #1190
Open
Sunnatillo wants to merge 1 commit into
Open
Sunnatillo wants to merge 1 commit into
Sunnatillo wants to merge 1 commit into
Conversation
Add the annotation storage.example.com/trident-fsgroup so users can set the UNIX group ID (GID) of an ONTAP NAS volume at provisioning time. The value is read from the PVC or StorageClass into the volume config, passed through the ONTAP driver's internal volume type, and applied as the NAS group ID on every volume-create call in the REST and ZAPI clients. An empty annotation or a GID of zero means "not set" and leaves the ONTAP default unchanged. The value must be an integer between 1 and 4294967294; anything else returns an error from volume creation. REST uses int64 and ZAPI uses int, so fsgroup_utils.go provides a parser for each. Only the ONTAP driver is affected. Mocks and existing tests are updated to pass the new argument. Signed-off-by: Sunnatillo <sunnat.samadov@est.tech>
Sunnatillo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
Add the annotation storage.example.com/trident-fsgroup so users can set the UNIX group ID (GID) of an ONTAP NAS volume at provisioning time. The value is read from the PVC or StorageClass into the volume config, passed through the ONTAP driver's internal volume type, and applied as the NAS group ID on every volume-create call in the REST and ZAPI clients.
An empty annotation or a GID of zero means "not set" and leaves the ONTAP default unchanged. The value must be an integer between 1 and 4294967294; anything else returns an error from volume creation. REST uses int64 and ZAPI uses int, so fsgroup_utils.go provides a parser for each.
Only the ONTAP driver is affected. Mocks and existing tests are updated to pass the new argument.
Project tracking
Do any added TODOs have an issue in the backlog?
Did you add unit tests? Why not?
Does this code need functional testing?
Is a code review walkthrough needed? why or why not?
Should additional test coverage be executed in addition to pre-merge?
Does this code need a note in the changelog?
Changelog
Does this code require documentation changes?
Additional Information