Skip to content

fix(ansible): replace removed yaml callback and print onboard token - #82

Open
priyams-netapp wants to merge 1 commit into
mainfrom
feature/console-local-ansible-playbooks-minor-fix1
Open

priyams-netapp wants to merge 1 commit into
mainfrom
feature/console-local-ansible-playbooks-minor-fix1

Conversation

@priyams-netapp

Copy link
Copy Markdown
Collaborator

Use ansible.builtin.default result_format=yaml so playbooks work after community.general 12 removed the yaml callback, and print the access token after login for reuse.

Summary

Changes

Checklist

General

  • No secrets, credentials, or API tokens in code or config
  • New examples live under <tool>/<product>/ (e.g. python/ontap/), not at the tool root
  • Updated catalog.yaml — including product — and the product README for new/changed examples (see CONTRIBUTING.md)

If touching python/

  • Scripts compile (python -m py_compile python/*/*.py)
  • Lint passes (ruff check python/)

If touching ansible/

  • Syntax check passes (ansible-playbook --syntax-check)
  • ansible-lint passes

If touching terraform/

  • terraform fmt -check passes
  • terraform validate passes

If touching go/

  • go vet ./... passes (from go/ directory)
  • go build -o /dev/null . passes for the changed program

Test Report

Environment:
Platform version:
Style touched:

First run

Command + output
$ <command here>
<paste 10-50 lines of output, redact secrets>

Idempotency / re-run

Second-run evidence
$ <same command, run again>
<for ansible: PLAY RECAP must show changed=0>
<for terraform: `terraform plan` must show "No changes">
<for python: explain expected behavior on re-run>

Cleanup / teardown

Teardown evidence (skip for read-only examples)
$ <teardown command>
<paste output>

Cannot run on a cluster?

Related issues

Use ansible.builtin.default result_format=yaml so playbooks work after community.general 12 removed the yaml callback, and print the access token after login for reuse.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

Copy link
Copy Markdown

Test Report missing or unfilled.

This PR touches python/, ansible/, terraform/, or go/, so a populated Test Report section is required in the PR body. See TESTING.md for what to capture (environment, platform version, first-run output, idempotency check, teardown).

This is a soft gate - your CI checks are unaffected - but reviewers will not approve until the report is filled in.

@github-actions

Copy link
Copy Markdown

Thanks for your first PR to Pace — welcome aboard.

Quick orientation:

  1. CI runs in ~2 minutes. If anything fails, check the Actions tab — most failures have a one-line fix in docs/troubleshooting.md.
  2. If your PR touches python/, ansible/, or terraform/, you'll be asked for a Test Report. It's worth the effort — reviewers rely on it.
  3. Make sure the NetApp CCLA is on file before review.
  4. Stuck? Comment on this PR and a maintainer will jump in. We aim to respond as soon as possible.

For background, see CONTRIBUTING.md.

@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown

A CI check failed — here is how to fix it

Workflow: Validate Examples · Run #55 · Failed jobs: 2

Terraform — fmt, validate & lint

Terraform format, validate, or tflint failed. Reproduce locally:

make terraform-validate

Most failures are formatting — fix all of them with:

terraform fmt -recursive terraform/

Ansible — syntax & lint

ansible-playbook --syntax-check or ansible-lint failed. Reproduce locally:

make ansible-lint

See docs/troubleshooting.md for common Ansible errors.

Push a fix and CI re-runs automatically; this comment updates with the next failure (or stays put if the same check fails again). Stuck? Comment on the PR and a maintainer will help — typical response time is 1 business day.

Auto-generated · explain-failure.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant