CSTACKEX-309: enabling resize volume Api validation notification to s… - #103
Open
sathvikaragi wants to merge 2 commits into
Open
sathvikaragi wants to merge 2 commits into
sathvikaragi wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…how up in UI
Description
When resizing a volume, backend API validation errors (e.g. invalid size value) are silently swallowed and never shown to the user.
This PR...
File: ui/src/views/storage/ResizeVolume.vue, lines 147–151
The .catch() handler uses this.$notification.error() with a hardcoded path error.response.data.errorresponse.errortext. However, the CloudStack API only uses errorresponse as the response key for unknown commands. For known commands like resizeVolume, it uses the command's own response name (resizevolumeresponse) as the key. So error.response.data.errorresponse is always undefined, causing a silent TypeError that swallows the error entirely.
$notifyError avoids this by using _.findKey() to find errortext regardless of what the key is named — which is why the same validation error shows correctly in UpdatePrimaryStorage.vue (which uses $notifyError) but not in ResizeVolume.vue.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?