Repository navigation
Allow NumPy 2 in dependency metadata - #43
Draft
CharlelieLrt wants to merge 1 commit into
Draft
CharlelieLrt wants to merge 1 commit into
CharlelieLrt wants to merge 1 commit into
Conversation
Signed-off-by: Charlelie Laurent <claurent@nvidia.com>
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
numpy<2.0.0dependency constraint so FastGen can installalongside packages that require NumPy 2. In particular, it allows the
PhysicsNeMo
diffusion-fastgenextra to resolve without weakening PhysicsNeMo'sNumPy dependency.
The change affects dependency metadata only. It does not change training
methods or public APIs, and it remains independent of the loss-hook proposal
in FastGen #44.
Dependencies
Depends on
mainand has no prerequisite PR.Depends on this PR
Later follow-ups
Related prerequisites
Independent proposal
Conditional follow-up
If FastGen maintainers decline FastGen #44, we would close PhysicsNeMo #2100.
The preceding PhysicsNeMo stack would remain available.
Review process
Reviewers can compare this PR with its immediate parent. After a parent merges,
we update the remaining branches and their PR bases to keep each diff focused.