Skip to content

fix(exec): any_sender completion signatures for sequence with 3+ senders #2223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alwaysprince05 wants to merge 3 commits into
base: main
Choose a base branch
from
+3 −3
Open

fix(exec): any_sender completion signatures for sequence with 3+ senders #2223

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
708187d
fix(exec): any_sender completion signatures for sequence with 3+ senders
alwaysprince05 Aug 22, 2026
5158d09
Revert "fix(exec): any_sender completion signatures for sequence with…
alwaysprince05 Aug 23, 2026
8dd53d1
fix(exec): sequence completion signatures for 3+ senders with any_sender
alwaysprince05 Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions include/stdexec/__detail/__sequence.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ namespace STDEXEC
// If the first sender has no set_value completions, then the second sender will
// never be started, so just return the (error and stopped) completions of the
// first sender.
return STDEXEC::get_completion_signatures<__cv_sender1_t, __fwd_env_t<_Env>...>();
return STDEXEC::get_completion_signatures<std::remove_cvref_t<__cv_sender1_t>, __fwd_env_t<_Env>...>();
}
else
{
Expand All @@ -398,11 +398,11 @@ namespace STDEXEC

auto __completions1 = //
STDEXEC::__transform_completion_signatures(
STDEXEC::get_completion_signatures<__cv_sender1_t, __fwd_env_t<_Env>...>(),
STDEXEC::get_completion_signatures<std::remove_cvref_t<__cv_sender1_t>, __fwd_env_t<_Env>...>(),
__eat_value_signatures<_Self>{});

auto __completions2 =
STDEXEC::get_completion_signatures<_Sender2, __env2_t<_Self, _Env>...>();
STDEXEC::get_completion_signatures<std::remove_cvref_t<_Sender2>, __env2_t<_Self, _Env>...>();

auto __eptr_completions =
STDEXEC::__eptr_completion_unless_t<__mbool<__nothrow_connect2>>();
Expand Down